Skip to content

Conversation

tompng
Copy link
Member

@tompng tompng commented Aug 5, 2024

Running test with ascii encoding fails LANG="" rake test

Error: test_document_with_dry_run(TestRDocRDoc): RDoc::Error: error generating index.html: "\xE2" on US-ASCII (Encoding::InvalidByteSequenceError)

http://ci.rvm.jp/logfiles/brlog.trunk.20240805-004507#L1586

Just like RDoc uses → instead of in output html, this pull request changes to ☰ to make the output html ascii-only again.

@@ -1,3 +1,3 @@
<button id="navigation-toggle" class="navigation-toggle" aria-label="Toggle sidebar" aria-expanded="true" aria-controls="navigation">
<span aria-hidden></span>
<span aria-hidden>&#9776;</span>
Copy link
Contributor

@olleolleolle olleolleolle Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it pass using &equals;? EDIT: Haha, no, this is a "vertical threequals" or rather "that hamburger menu icon"!

https://www.toptal.com/designers/htmlarrows/symbols/trigram-for-heaven/

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the hamburger menu icon ("trigram for heaven") in all situations.

@olleolleolle olleolleolle merged commit 40a6690 into ruby:master Aug 5, 2024
@tompng tompng deleted the ascii_html branch August 5, 2024 08:12
@st0012 st0012 added this to the v6.8.0 milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants